Feature/osidb 3129 multi flaws related trackers #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMarble
reviewed
Aug 12, 2024
superbuggy
force-pushed
the
feature/OSIDB-3129-multi-flaws-related-trackers
branch
from
50bdf0e
to
609f34e
Compare
superbuggy
force-pushed
the
feature/OSIDB-3129-multi-flaws-related-trackers
branch
from
609f34e
to
2e07344
Compare
superbuggy
force-pushed
the
feature/OSIDB-3129-multi-flaws-related-trackers
branch
from
cacdd1e
to
7284066
Compare
🐛 Remove merge artefacts 🐛 Fix check for affect presence 🐛 Fix unmount cleanup function on loading directive The cause seems to have been 'patch-style' updates to pieces of the DOM that were done via hot-reloading. ♻️ Ensure type signature 🚧 Request trackers for related flaws OSIDB endpoint seems to be returning only trackers for affect of current flaw. ✨ Provide new Tabs component with dynamic slot scopes 🚧 Provide UI for multiflaws Filing trackers doesn't work due to module_components from OSIDB's tracker querying endpoint only having an association with a single affect. ♻️ Unpack object error values from OSIDB error response data 🚧 Synchronize tracker selections 💄 Use tracker theme color for trackers manager 💄 Use tracker theme color for trackers manager 💄 Use tracker theme color on related Flaw tabs 💄 Refine trackers manager layout ✨ Connect filing for multiple flaws 🔥 Remove unused file 🏷️ Improve type safety
💄 Make untrackable affects alert full-screen 🔥 Remove unused functions 💄 Refine trackers manager layout
MrMarble
reviewed
Sep 17, 2024
superbuggy
force-pushed
the
feature/OSIDB-3129-multi-flaws-related-trackers
branch
from
213bae7
to
5cdc3a6
Compare
MrMarble
reviewed
Sep 17, 2024
There was a problem hiding this comment.
This probably was reverted during merge. it was change don #387
C-Valen
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Friendly reminder on the points commented on the code review meeting:
- Style issue in some local instances (e.g. trackers table background disappear)
- Add tracker button (file trackers for individual affect) not currently working
isSelectableFnpossible renaming?- Double scroll on tracker manager lists?
MrMarble
reviewed
Sep 19, 2024
Comment on lines
40
to
52
| function filterAffects(affects: ZodAffectType[]): ZodAffectType[] { | ||
| return affects.filter((affect) => { | ||
| const matchesSelectedModules = | ||
| selectedModules.value.length === 0 || selectedModules.value.includes(affect.ps_module); | ||
| const matchesAffectednessFilter = | ||
| affectednessFilter.value.length === 0 || affectednessFilter.value.includes(affect.affectedness ?? ''); | ||
| const matchesResolutionFilter = | ||
| resolutionFilter.value.length === 0 || resolutionFilter.value.includes(affect.resolution ?? ''); | ||
| const matchesImpactsFilter = | ||
| impactFilter.value.length === 0 || impactFilter.value.includes(affect.impact ?? ''); | ||
| return matchesSelectedModules && matchesAffectednessFilter && matchesResolutionFilter && matchesImpactsFilter; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Possible suggestion to follow DRY principle
Suggested change
| function filterAffects(affects: ZodAffectType[]): ZodAffectType[] { | |
| return affects.filter((affect) => { | |
| const matchesSelectedModules = | |
| selectedModules.value.length === 0 || selectedModules.value.includes(affect.ps_module); | |
| const matchesAffectednessFilter = | |
| affectednessFilter.value.length === 0 || affectednessFilter.value.includes(affect.affectedness ?? ''); | |
| const matchesResolutionFilter = | |
| resolutionFilter.value.length === 0 || resolutionFilter.value.includes(affect.resolution ?? ''); | |
| const matchesImpactsFilter = | |
| impactFilter.value.length === 0 || impactFilter.value.includes(affect.impact ?? ''); | |
| return matchesSelectedModules && matchesAffectednessFilter && matchesResolutionFilter && matchesImpactsFilter; | |
| }); | |
| } | |
| const matchAffectFilter = <T extends Ref>(filter: T, field: string) => | |
| filter.value.length === 0 || filter.value.includes(field ?? ''); | |
| function filterAffects(affects: ZodAffectType[]): ZodAffectType[] { | |
| return affects.filter(affect => | |
| matchAffectFilter(selectedModules, affect.ps_module) | |
| && matchAffectFilter(affectednessFilter, affect.affectedness) | |
| && matchAffectFilter(resolutionFilter, affect.resolution) | |
| && matchAffectFilter(impactFilter, affect.impact), | |
| ); | |
| } |
There was a problem hiding this comment.
This has been fixed already, so another rebase? 😓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[OSIDB-ID] [Title]
Checklist:
Summary:
[Replace with a brief summary of the changes introduced by this PR.]
Changes:
[Replace with a detailed description of the changes made in this PR, including any new features, enhancements, bug fixes, or refactorings.]
Considerations:
[Replace with any additional considerations, notes, or instructions for reviewers.]